Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetris_game feature request: consistent tetromino queue distribution algorithm #19

Open
ajtran303 opened this issue Sep 27, 2023 · 2 comments

Comments

@ajtran303
Copy link

Thank you for implementing Tetris in Flipper. I enjoy this game. I have one feedback.

I noticed that the tetronimo (Tetris block) distribution is quite random. There were many moves until I got an "I" / line block.

In reviewing the codebase, I don't find any specific logic to handle the queueing of Tetris pieces. So this is my suggestion!

In modern versions of Tetris, tetrominos are now distributed on a semi-random basis.

For example: given a set of pieces A, B, C and D... the algorithm would randomize the order of that whole set before distribution:

D, B, C, A

And then once the whole set has been distributed, it will randomize it again, etc:

B, A, D, C

The significance of this feature is that the game feels more consistent for the player, and it is arguably more enjoyable :)

@xMasterX
Copy link
Owner

xMasterX commented Oct 3, 2023

Good idea, will be done later

@noiob
Copy link
Contributor

noiob commented Nov 7, 2023

I implemented the standard 7-bag randomizer in my PR, try it out :) #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants