Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depth of field + outline #50

Open
mattwelborn opened this issue May 2, 2015 · 1 comment
Open

Depth of field + outline #50

mattwelborn opened this issue May 2, 2015 · 1 comment
Labels

Comments

@mattwelborn
Copy link
Collaborator

Depth of field and outlining create halos of ripples around atoms. (Perhaps this is due to applying a sinc filter to the hard black lines?) Can we mix in some jittering or noise into the DoF calculation to remove this structure?

render 17

@mattwelborn mattwelborn added the bug label May 2, 2015
@wwwtyro
Copy link
Owner

wwwtyro commented May 2, 2015

For the ripple effect, an easy short-term solution might be to allow the user to increase the number of samples, which I'd expect to blur them from perception.

The halos (which can be present absent the outline) are symptomatic of the simple DOF algorithm I've implemented. We'd need to implement a more sophisticated algorithm to get correct results. It may also address the ripples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants