Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement predict. generic for all models #141

Open
wwiecek opened this issue Jun 9, 2022 · 4 comments
Open

implement predict. generic for all models #141

wwiecek opened this issue Jun 9, 2022 · 4 comments
Milestone

Comments

@wwiecek
Copy link
Owner

wwiecek commented Jun 9, 2022

To bring this in line with other rstan packages.

@wwiecek
Copy link
Owner Author

wwiecek commented Jun 17, 2022

posterior_predict could have a 3-fold function:

  • alias for effect_draw (average effect in a new setting)
  • predict distributions for new studies with fixed characteristics (newdata = ...)
  • predictive distributions for the existing K studies which is sort of implemented in predict. generic, but should use group_effects instead

@wwiecek
Copy link
Owner Author

wwiecek commented Jun 18, 2022

What if newdata has logical type columns but either FALSE or TRUE is not present? Will model.matrix not break things?

@wwiecek
Copy link
Owner Author

wwiecek commented Jun 21, 2022

Update: as of 0.7.1 we only need to implement the third bulletpoint in the list above.

@wwiecek wwiecek changed the title alias effect_draw and posterior_predict() implement predict. generic for all models Jun 21, 2022
@wwiecek
Copy link
Owner Author

wwiecek commented Dec 18, 2023

Also need posterior_predict() and posterior_interval(). See #34 for much older conversations on this

@wwiecek wwiecek added this to the v0.8 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant