Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary outcome data without grouping column #121

Open
wwiecek opened this issue Dec 24, 2021 · 2 comments
Open

binary outcome data without grouping column #121

wwiecek opened this issue Dec 24, 2021 · 2 comments
Milestone

Comments

@wwiecek
Copy link
Owner

wwiecek commented Dec 24, 2021

df <- data.frame(
  n1 = rep(500, 10),
  a = c(rep(28,9), 3),
  n2 = rep(500, 10),
  c = c(rep(30,9), 1)
)
baggr(df)

For Rubin model it's automatically added, but for prepare_ma apparently not

@wwiecek
Copy link
Owner Author

wwiecek commented Feb 24, 2022

Currently, in group_effect.R:43

  # Grab group labels
  if(is.null(attr(bg$inputs, "group_label")))
    par_names <- paste0("Group ", 1:attr(bg$inputs, "n_groups"))
  else
    par_names <- attr(bg$inputs, "group_label")

This should be done inside convert_inputs.R and preferably where I currently say "does not exist in data. No labels will be added"

@wwiecek wwiecek added this to the v0.7 milestone Feb 24, 2022
@wwiecek
Copy link
Owner Author

wwiecek commented May 18, 2022

Other fixes in #140 are currently throwing this off. I get different problems depending on whether I go baggr(df, model = "rubin") or baggr(df, model = "logit"). This snippet, convert_inputs:103 to blame:

  if(model == "rubin" && available_data == "pool_binary")
    available_data <- required_data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant