Skip to content
This repository has been archived by the owner on Apr 5, 2021. It is now read-only.

Incorrect Ecovacs continent code for some countries #86

Open
realbigest opened this issue Dec 7, 2019 · 4 comments
Open

Incorrect Ecovacs continent code for some countries #86

realbigest opened this issue Dec 7, 2019 · 4 comments

Comments

@realbigest
Copy link

Now Sucks uses pycountry_convert to determine continent code for Ecovacs servers from entered country code. In most cases it’s ok, but there is some exclusions. For example Russia (“ru” country code) now mapping to Europe (“eu” continent code), but Ecovacs apps connecting to “ww” servers.

Maybe we need some dictionary In code for assign known exclusions?

@wpietri
Copy link
Owner

wpietri commented Dec 9, 2019

I think that's a fine idea. Feel free to put together an exception for just the wrong countries that you know; we can always add more later. But if you're feeling ambitious, I suspect the full list could be extracted from a decompiled version of their Android app.

@jyz0501
Copy link

jyz0501 commented Mar 4, 2020

No CN country code

@jyz0501
Copy link

jyz0501 commented Mar 4, 2020

Keep an eye on this issue

@dcwilli
Copy link

dcwilli commented Jan 6, 2021

anyone know the Australian continent code?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants