Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new PHPCSStandards/PHP_CodeSniffer package #1827

Closed
2 tasks
mindctrl opened this issue Mar 1, 2024 · 1 comment
Closed
2 tasks

Switch to new PHPCSStandards/PHP_CodeSniffer package #1827

mindctrl opened this issue Mar 1, 2024 · 1 comment
Assignees
Labels
good first issue Issue that doesn't require previous experience with codebase

Comments

@mindctrl
Copy link
Contributor

mindctrl commented Mar 1, 2024

The Squizlabs/PHP_CodeSniffer package has been deprecated. It has been forked and will be maintained under a new package at PHPCSStandards/PHP_CodeSniffer.

Reference: The Future of PHP_CodeSniffer · Issue #3932 · squizlabs/PHP_CodeSniffer

Acceptance Criteria

  • Existing squizlabs package is removed and replaced with the new one.
  • Existing phpcs tests continue to pass. If failures happen after upgrading, the changes needed to make it pass should happen in the same PR.
@mindctrl mindctrl added good first issue Issue that doesn't require previous experience with codebase tooling labels Mar 1, 2024
@ChrisWiegman
Copy link
Contributor

While the link here indicates that we didn't need to actually change the package name (they managed to keep the same namespace on Packagist), I did update us to versions of WPCS and phpcs that followed the changes from the original change in #1894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue that doesn't require previous experience with codebase
Projects
None yet
Development

No branches or pull requests

2 participants