Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action workflow validation #84

Open
danielbachhuber opened this issue Nov 1, 2023 · 3 comments
Open

Add GitHub action workflow validation #84

danielbachhuber opened this issue Nov 1, 2023 · 3 comments

Comments

@danielbachhuber
Copy link
Member

We tried and failed previously: #81

It would be nice to get this working again.

I think we should create a new workflow file to temporarily test from, so we don't fail builds across all repos.

@jrfnl
Copy link
Contributor

jrfnl commented Oct 1, 2024

Might be a nice first step to add a yamllint workflow ? That should at least prevent typos and such from being merged in. (sorry, my bad, I made one earlier)

@tfrommen
Copy link
Contributor

tfrommen commented Oct 7, 2024

@danielbachhuber I added a new job using actionlint in #111. I know that you (specifically, @swissspidy) tried to use action-validator before, so can you maybe take a look if that would work for you instead?

@swissspidy
Copy link
Member

Ah yes, I forgot about that. We added it in #79 but it didn't really work, there were some installation issues on CI that we couldn't figure out. Reverted in #83.

I don't know the difference between the two tools, but at first glance actionlint seems to be way more popular and battle-tested, so chances are higher that it works for us.

So #111 looks promising. I'll re-review ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants