Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of transparency in some game images #8

Open
timkurvers opened this issue May 21, 2018 · 0 comments
Open

Lack of transparency in some game images #8

timkurvers opened this issue May 21, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@timkurvers
Copy link
Member

timkurvers commented May 21, 2018

Some game images exhibit a black background and lack transparency:

screen shot 2018-05-21 at 17 57 04

This could be a bug/issue in our usage of libblp from BLPConverter.

Alternatively it could be an issue with how Spelunker converts a single mipmap to a transparent PNG:

BLP.from(req.resource.data, (blp) => {
  const mipmap = blp.largest;

  const png = new PNG({ width: mipmap.width, height: mipmap.height });
  png.data = mipmap.rgba;

  res.type('image/png');
  png.pack().pipe(res);
});
@timkurvers timkurvers added the bug Something isn't working label Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant