Add widgets client and get token API support #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgd
force-pushed
the
feature/auth-3897-go-sdk-support-for-widget-tokens
branch
from
c0df1a6
to
22d3611
Compare
mattgd
commented
Nov 14, 2024
|
|
||
| ## How it works | ||
|
|
||
| See the [Widgets integration guide](https://workos.com/docs/widgets/guide). |
There was a problem hiding this comment.
This page doesn't exist yet and should be updated before merging.
PaulAsjes
approved these changes
Nov 15, 2024
| } | ||
|
|
||
| if c.Endpoint == "" { | ||
| c.Endpoint = "https://api.workos.com" |
There was a problem hiding this comment.
This should ideally be configurable. You can't currently change the API host in the golang SDK, but it's something we should add and that should reflect here too.
There was a problem hiding this comment.
Great point. I also feel like it's less than ideal that we have to redefine this common client logic for every module. Wondering if it should be refactored into a shared module.
mattgd
deleted the
feature/auth-3897-go-sdk-support-for-widget-tokens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add widgets client and get token API support.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.