Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle multiple windows for same buffer #11

Open
FelipeLema opened this issue Jul 19, 2023 · 2 comments · May be fixed by #12
Open

handle multiple windows for same buffer #11

FelipeLema opened this issue Jul 19, 2023 · 2 comments · May be fixed by #12
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone
0.3.0

Comments

@FelipeLema
Copy link

FelipeLema commented Jul 19, 2023 •
edited
Loading

I cannot reproduce this consistently, but moving around splits with more-than-one buffers (2 should be enough?), using at least 2 splits for 1 buffer, makes the semshi highlighting go away. If I jump back into this window, semshi will re-highlight it all right

it seems that jumping around makes "the latest window focused" not being considered? I'm not sure if semshi will clear previous highlights from "anything that's not the current window"
@FelipeLema
Copy link
Author

I can do a PR to iterate over all windows / viewports for a buffer, but that will have a slight impact on performance

@wookayin
Copy link
Owner

wookayin commented Aug 2, 2023

I've seen this bug before and it was quite hard to reproduce for me too. But if you have any clues, I'd be happy to investigate together.

@wookayin wookayin added bug Something isn't working help wanted Extra attention is needed labels Aug 2, 2023
FelipeLema added a commit to FelipeLema/semshi that referenced this issue Aug 3, 2023
@FelipeLema
reproducible experiment
046b182 
- run `nvim -S reproducible_vimsession.vim`
- move around the windows, eventually you'll hit a de-coloring as
described in wookayin#11
@FelipeLema FelipeLema linked a pull request Aug 17, 2023 that will close this issue
Open
@wookayin wookayin added this to the 0.3.0 milestone Sep 26, 2023
FelipeLema added a commit to FelipeLema/semshi that referenced this issue Oct 2, 2023
@FelipeLema
reproducible experiment
b965b74 
- run `nvim -S reproducible_vimsession.vim`
- move around the windows, eventually you'll hit a de-coloring as
described in wookayin#11
FelipeLema added a commit to FelipeLema/semshi that referenced this issue Apr 17, 2024
@FelipeLema
reproducible experiment
d92c081 
- run `nvim -S reproducible_vimsession.vim`
- move around the windows, eventually you'll hit a de-coloring as
described in wookayin#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

fix handling multiple windows for a buffer - fix #11 FelipeLema/semshi
2 participants
@wookayin @FelipeLema