Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++17 has dropped support for dynamic exceptions #37

Closed
badshah400 opened this issue Jun 13, 2021 · 3 comments · May be fixed by #38
Closed

C++17 has dropped support for dynamic exceptions #37

badshah400 opened this issue Jun 13, 2021 · 3 comments · May be fixed by #38

Comments

@badshah400
Copy link

GCC 11 uses the C++17 standard, which has dropped support for dynamic exceptions, by default. As a result, building fityk on a distro with GCC 11 as the default compiler (such as openSUSE Tumbleweed) causes compilation errors due to throws like these:

fityk/fityk/fityk.h

Line 335 in d981589

get_covariance_matrix(int dataset=ALL_DATASETS) throw(ExecuteError);

I can simply switch to forcing C++11 or C++14 when compiling, but I thought I'd get an opinion from you. Thanks for the great app.
@SoapGentoo
Copy link

The correct solution is to remove dynamic exception specifications, which are considered a mistake in the history of C++.

@SoapGentoo SoapGentoo mentioned this issue Jun 14, 2021
Open
@wojdyr
Copy link
Owner

wojdyr commented Jun 16, 2021

Hi @badshah400
I forgot to reply. I'll modernize the code at some point, but I don't know when, unfortunately I don't spend much time maintaining fityk nowadays. Currently, it's still C++98 and should compile up to C++14.
The last release (that was made years ago) also doesn't work well with GTK3. I think I've fixed most of the issues in git. l need to make a new release soon.

@wojdyr wojdyr closed this as completed Jun 16, 2021
@badshah400
Copy link
Author

Thanks, we enforced c++14 to fix our package. Looking forward to a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dynamic exception specifications
3 participants
@wojdyr @badshah400 @SoapGentoo