Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new version with child lock support #147

Closed
proohit opened this issue Jan 17, 2025 · 9 comments
Closed

Release new version with child lock support #147

proohit opened this issue Jan 17, 2025 · 9 comments
Assignees

Comments

@proohit
Copy link

proohit commented Jan 17, 2025

Hey there and thanks for PyTado! Using it for home assistant has been a huge improvement in my smart home setup.

As I and many more are missing child lock support, I wanted to add support for it to Home Assistant. I see that this has already been implemented, but not released yet. I've implemented and tested support for it in Home Assistant, but in order to finally complete it, we need a version bump.

Is there any ETA for this feature to be released (maybe 0.19.0)? Many thanks and have a nice weekend!

See PR home-assistant/core#135837

@wmalgadey
Copy link
Owner

We are working on full tado x support and release 1.0.0. If the current functionality is working, there should not be any problem to release asap. What do you think @erwindouna?

@erwindouna
Copy link
Collaborator

We are working on full tado x support and release 1.0.0. If the current functionality is working, there should not be any problem to release asap. What do you think @erwindouna?

The current functions create on regular Tado and you tested it on Tado X, if I am correct.
It would be fine to release a small patch version only including the child lock. It is also asked within the Home Assistant community, so it seems popular. ;)

@proohit
Copy link
Author

proohit commented Jan 26, 2025

Yes I would be careful with the breaking changes in the interfaces. If I'm not wrong, the changes in interface would break the current implementation in home assistant (it uses PyTado.interface.Tado which does not expose snake case methods). I had to use PyTado.interface.api.my_tado.Tado because it provides the snake case methods. Those are not present in PyTado.interface.Tado

@wmalgadey
Copy link
Owner

wmalgadey commented Jan 26, 2025

@proohit are you able to test the changes from hotfix/0.18.6 branch introduced with #149? If they are working, I would merge them to support/0.18 and create a release 0.18.6, which should be 100% compatible with current 0.18.5 release.

@proohit
Copy link
Author

proohit commented Jan 26, 2025

Hey @wmalgadey and thanks for the quick update. I'm happy to report that there were no breaking changes in 0.18.6 and child lock works.

Although for some reason, pip reported to have installed python-tado-0.19.0. I can't really understand why, see logs below.

(ha-venv) vscode ➜ /workspaces/core (feature/tado-child-lock-support) $ pip uninstall python-tado
Found existing installation: python-tado 0.19.0
Uninstalling python-tado-0.19.0:
  Would remove:
    /home/vscode/.local/ha-venv/bin/pytado
    /home/vscode/.local/ha-venv/lib/python3.13/site-packages/PyTado/*
    /home/vscode/.local/ha-venv/lib/python3.13/site-packages/python_tado-0.19.0.dist-info/*
Proceed (Y/n)? y
  Successfully uninstalled python-tado-0.19.0
(ha-venv) vscode ➜ /workspaces/core (feature/tado-child-lock-support) $ pip install git+https://github.com/wmalgadey/PyTado.git#hotfix/0.18.6
Collecting git+https://github.com/wmalgadey/PyTado.git#hotfix/0.18.6
  Cloning https://github.com/wmalgadey/PyTado.git to /tmp/pip-req-build-2qh2m954
  Running command git clone --filter=blob:none --quiet https://github.com/wmalgadey/PyTado.git /tmp/pip-req-build-2qh2m954
  Resolved https://github.com/wmalgadey/PyTado.git to commit 65449f020f41c085273315c8f0bed42f39fceef2
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: requests in /home/vscode/.local/ha-venv/lib/python3.13/site-packages (from python-tado==0.19.0) (2.32.3)
Requirement already satisfied: charset-normalizer<4,>=2 in /home/vscode/.local/ha-venv/lib/python3.13/site-packages (from requests->python-tado==0.19.0) (3.4.0)
Requirement already satisfied: idna<4,>=2.5 in /home/vscode/.local/ha-venv/lib/python3.13/site-packages (from requests->python-tado==0.19.0) (3.10)
Requirement already satisfied: urllib3<3,>=1.21.1 in /home/vscode/.local/ha-venv/lib/python3.13/site-packages (from requests->python-tado==0.19.0) (1.26.20)
Requirement already satisfied: certifi>=2017.4.17 in /home/vscode/.local/ha-venv/lib/python3.13/site-packages (from requests->python-tado==0.19.0) (2024.12.14)
Building wheels for collected packages: python-tado
  Building wheel for python-tado (pyproject.toml) ... done
  Created wheel for python-tado: filename=python_tado-0.19.0-py3-none-any.whl size=49937 sha256=9fa0dfdd13be4de38d49d927a0a009bb888b6b6dff760637f9227e82cb4e9022
  Stored in directory: /tmp/pip-ephem-wheel-cache-y0cj73r3/wheels/3b/51/0c/76cba717b7a596b15c6886f1074cbe2caee9644e9cca6b655e
Successfully built python-tado
Installing collected packages: python-tado
Successfully installed python-tado-0.19.0

@wmalgadey
Copy link
Owner

I just recently changed the version to 0.19.0 😄

I will merge my hotfix-changes and tag a 0.18.6 release. @erwindouna you have to update the home assistant integration, right?

@proohit
Copy link
Author

proohit commented Jan 26, 2025

Ah got it :D

The version used in Home Assistant is currently fixed to 0.18.5. In my PR (home-assistant/core#135837), I'm working on integrating child lock. As soon as the version is released, I can add a version bump to the manifest.

@wmalgadey
Copy link
Owner

Done, release already published to pypi 😁

@erwindouna
Copy link
Collaborator

I just recently changed the version to 0.19.0 😄

I will merge my hotfix-changes and tag a 0.18.6 release. @erwindouna you have to update the home assistant integration, right?

Yes, which I can do any time now. Thanks @wmalgadey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants