-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release new version with child lock support #147
Comments
We are working on full tado x support and release 1.0.0. If the current functionality is working, there should not be any problem to release asap. What do you think @erwindouna? |
The current functions create on regular Tado and you tested it on Tado X, if I am correct. |
Yes I would be careful with the breaking changes in the interfaces. If I'm not wrong, the changes in interface would break the current implementation in home assistant (it uses |
Hey @wmalgadey and thanks for the quick update. I'm happy to report that there were no breaking changes in 0.18.6 and child lock works. Although for some reason, pip reported to have installed python-tado-0.19.0. I can't really understand why, see logs below.
|
I just recently changed the version to 0.19.0 😄 I will merge my hotfix-changes and tag a 0.18.6 release. @erwindouna you have to update the home assistant integration, right? |
Ah got it :D The version used in Home Assistant is currently fixed to 0.18.5. In my PR (home-assistant/core#135837), I'm working on integrating child lock. As soon as the version is released, I can add a version bump to the manifest. |
Done, release already published to pypi 😁 |
Yes, which I can do any time now. Thanks @wmalgadey! |
Hey there and thanks for PyTado! Using it for home assistant has been a huge improvement in my smart home setup.
As I and many more are missing child lock support, I wanted to add support for it to Home Assistant. I see that this has already been implemented, but not released yet. I've implemented and tested support for it in Home Assistant, but in order to finally complete it, we need a version bump.
Is there any ETA for this feature to be released (maybe 0.19.0)? Many thanks and have a nice weekend!
See PR home-assistant/core#135837
The text was updated successfully, but these errors were encountered: