Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global banner support (via banner api) #148

Open
JasonLovesDoggo opened this issue Dec 19, 2023 · 2 comments
Open

Add global banner support (via banner api) #148

JasonLovesDoggo opened this issue Dec 19, 2023 · 2 comments
Assignees
@nelimalu
Milestone
Deploy

Comments

@JasonLovesDoggo
Copy link
Member

reqs:

  • dynamically fetch banner from api
  • if returns more than one, cycle through them (DONT STACK)
@JasonLovesDoggo
Copy link
Member Author

see https://github.com/wlmac/metropolis/blob/8bf520e5fdc2ef995f39afd8d92c863d90e20232/core/templates/core/base.html#L42

but when more than banner exists, cycle through with a sliding ltr animation.

@JasonLovesDoggo
Copy link
Member Author

Please ping json before working on this.

I want to get thoughts on custom timing for diff ones/scrolling text.

@nyiyui nyiyui added this to the Deploy milestone Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelimalu nelimalu

Labels
None yet
Projects
None yet
Milestone
Deploy
Development

No branches or pull requests
3 participants
@nyiyui @nelimalu @JasonLovesDoggo