Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN 0.57 and xcode 10 issue #144

Open
arneson opened this issue Oct 22, 2018 · 5 comments
Open

RN 0.57 and xcode 10 issue #144

arneson opened this issue Oct 22, 2018 · 5 comments

Comments

@arneson
Copy link

arneson commented Oct 22, 2018

Build fails with error:

Multiple methods named 'goForward' found with mismatched result, parameter type or attributes
in goForward EXPORT_METHOD in RCTWebViewBridgeManager.m file for xcode 10 and react native 0.57.1

Can be fixed by using live fork of react-native-webview-bridge.

This was referenced Oct 22, 2018
@rajatdutta
Copy link

rajatdutta commented Nov 6, 2018

Hi @arneson ,
While running the exact example my RichTextToolbar is just blank, it only appears when I remove the ListView in RichTextToolbar.js render method and undo that remove and save.
Facing a warning, how did you get it running on 0.57 ?

RichTextToolbar has a method called componentDidReceiveProps(). But there is no such lifecycle method. If you meant to update the state in response to changing props, use componentWillReceiveProps()

@arneson
Copy link
Author

arneson commented Nov 19, 2018

@rajatdutta
That warning you are referring to still remain for me, doesn't appear to have any negative effects however.

I have experienced the problem you're describing, but what occurred when I tried to update react-navigation to 2.18.4 (or 3 for that matter). Keeping react-navigation on v. 2.0.4 solved that for me.

I'll try to remember to go back here when I've give my self the time to update react-navigation and solve the problem.

@arneson
Copy link
Author

arneson commented Nov 19, 2018

@rajatdutta
Worth noting is that I've merged a bunch of PRs and fixed the warning as well as this issue in my fork (https://github.com/arneson/react-native-zss-rich-text-editor). There is a PR pending #146 for this as well, but you can of course use my fork if you'd like.

@morenoh149
Copy link

@arneson have you been using your fork? if the main repo isn't merging fixes I'll be using your fork :)

@arneson
Copy link
Author

arneson commented Feb 22, 2019

@morenoh149
Hey,
Yeah we're using my fork, go ahead! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants