[1.21] Fix issues with Codec <-> Endec interop issues involved with NBT #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrites logic to fix issues involved with using EDM as Nbt format is so bad that it just has to many problematic edge cases leading to issues with various data objects like optional and lists
Dragon-Seeker
changed the title
- Add Interop for Gson
- improve naming - replace the majority of nasty casts with better dynamics usage - enforce that the (De)Serializer types of a CodecAdapter are self-described
gliscowo
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseds #306 due to git fun
Rewrites logic to fix issues involved with using EDM as Nbt format is so bad that it just has to many problematic edge cases leading to issues with various data objects like optional and lists