[1.21] Codec conversion adjustments #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: BasiqueEvangelist <[email protected]>
Don't look here as this commit dose not exist within your eye balls nor the universe that you may or may not be living in so I recommend you get back to bed and forget about everything that has happened today
BasiqueEvangelist
suggested changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
ofMapCodecallowing the ability to convert aMapCodecto aStructEndeccombined with code refactors to clean duplicate method calls within the class and adjust buildingRegistriesAttributeto attempt to get DRM from lookup.Thanks to @BasiqueEvangelist for discovering the very cursed work around for the conversion method
Supersedes #270 and #257