[1.21] Field Registraction Adjustments #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Inject supplier into RegistryEntry - MemoizedSupplier's that caches the first get call made to the supplier
- Made such abstract classes instead of interfaces to allow for direct calls to entry method on AutoRegistryContainer - Fix MemoizedEntry name - Move iterateAccessibleStaticFieldsAllowingMemorizedSuppliers to FieldRegistrationHandler
|
Note: This will cause breaking changes fyi |
BasiqueEvangelist
suggested changes
Jul 20, 2024
src/main/java/io/wispforest/owo/registration/reflect/FieldRegistrationHandler.java
Outdated
Show resolved
Hide resolved
| import java.util.function.Supplier; | ||
|
|
||
| public class MemoizedEntry<T> implements Supplier<T> { | ||
|
|
There was a problem hiding this comment.
is this class needed if there already is a helper method on AutoRegistryContainer for making a MemoizedRegistryEntry? any people who only want a supplier can still use the registry entry class since you made it extend supplier
…efore type checks
…variant instead of base supplier
- Refactor folder structure - FIx `register` method on `AutoRegistryContainer` being unavailable due to being package private
Closed
|
Closing this as such changes with Item, Block, and EntityType basically make it nearly impossible to use AutoRegistryContainer tbh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the Field registration API to handle Registry Entries combined with a supplier method of deferred registration