Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow wisdom-maven-plugin to properly terminate background wisdom when maven ends #567

Open
Riduidel opened this issue Feb 21, 2017 · 0 comments

Comments

@Riduidel
Copy link
Contributor

on Windows, when maven build launching wisdom terminates, the chameleon.sh continues its execution, which is quite a pain, since it locks the port used by Wisdom and prevents any re-execution.

Could it possible, in such a case, to register a JVM shutdown hook that will, when invoked, terminate the chameleon run ?

It seems to me that launching is done in WisdomExecutor#executeInBackground(...).
More precisely, the line

        Runtime.getRuntime().exec(cmdLine.toStrings(), null, mojo.getWisdomRootDirectory()); //NOSONAR see comment

creates a process, but never connects to it, which prevents its proper termination.

As a side note, i know that this works on MacOS/Linux, but not everybody wants to use these platforms :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant