Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAML generation fails if the route uri is a string that contains referenced constant #500

Open
tleveque opened this issue May 9, 2015 · 5 comments

Comments

@tleveque
Copy link

tleveque commented May 9, 2015

No description provided.

@cescoffier
Copy link
Member

Yes, it is probably something we cannot really fix. The RAML processing is based on the JAVA AST, so we don't have the value of the constants.

@tleveque
Copy link
Author

Could we detect this case and load the class to evaluate uri value ? This second compile phase can be skipped when uri value is simpler.
A second workaround would be to support only when the constants are defined into the processed class and compute uri value on the fly during Java AST parsing.

@tleveque
Copy link
Author

I propose that my team will work on evaluating uri value with constants that are only defined into the same class as a first stepIs it ok for you ?

@cescoffier
Copy link
Member

Cool !

I discuss with @barjo yesterday, and I think we would eventually look for a mechanism to merge compilation and runtime data. However, does not really help for constants, so your way is already a good step.

@barjo
Copy link
Member

barjo commented May 15, 2015

As we discuss yesterday (with Thomas ;) ) I think that's the more appropriate way to do it for now. Especially if don't want to have to handle the class during the watch mode, which can be very tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants