Add a null check in the equals method

Signed-off-by: Clement Escoffier <[email protected]>

Author: cescoffier

framework/resource-controller/src/main/java/org/wisdom/resources/WebJarDeployer.java

@@ -244,7 +244,7 @@ public synchronized void stop() {
      * A structure holding a webjar found in a jar file.
      * Don't forget that a single jar file can contain any number of libraries.
      */
-    private static class DetectedWebJar {
+    private static final class DetectedWebJar {
 
         /**
          * The id computed as follows: {@code name-version}.
@@ -291,7 +291,10 @@ private DetectedWebJar(String name, String version, String path, File file) {
          */
         @Override
         public boolean equals(Object obj) {
-            return obj.getClass().equals(DetectedWebJar.class) && id.equals(((DetectedWebJar) obj).id);
+            // We don't use instanceOf because we don't need inheritance (the class if final).
+            return obj != null // Check not null
+                    && obj.getClass().equals(DetectedWebJar.class) // Check it's the right class
+                    && id.equals(((DetectedWebJar) obj).id); // Check id
         }
 
         /**