Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for merge_queue #546

Open
GoetzGoerisch opened this issue Mar 23, 2023 · 2 comments
Open

Add support for merge_queue #546

GoetzGoerisch opened this issue Mar 23, 2023 · 2 comments

Comments

@GoetzGoerisch
Copy link

GitHub is recently introduced merge_queue.
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue

Currently the WIP check does pass if a PR is added to the merge_queue even though it passed in the initial PR.

Related issue from cla-assistant and there solution.

Would be great, if this could be added.

@gr2m
Copy link
Collaborator

gr2m commented May 28, 2023

I'd be happy to accept a pull request, I didn't run into the problem mysel and haven't worked with merge queue yet

@webknjaz
Copy link

+1. This deadlocks merges when used with branch protection. This is what this looks like:
Screenshot_2023-10-26-19-21-01-12_40deb401b9ffe8e1df2f1cc5ba480b12

As for the events, GitHub generates two — merge_group for when a PR is added to the queue, but it also merges the PRs in the queue together into a temporary branch, which is an implementation detail but it also means there's a push event.

So basically, it'd be necessary to report a new Checks API status for one of these events. For the push event, it's possible to filter out the related ones by the read-only tmp branch pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants