Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency glossy is unmaintained #232

Open
ClementValot opened this issue Nov 19, 2023 · 4 comments
Open

Dependency glossy is unmaintained #232

ClementValot opened this issue Nov 19, 2023 · 4 comments

Comments

@ClementValot
Copy link

The glossy library, responsible for formatting syslog messages according to RFC5424 (GitHub - NPM), has been unmaintained for years.

It has, notably what brought me to this issue, a commit from december 2015, that fixes an issue that prevents the package from operating in a 'use strict' js environment, or to be correctly bundled by e.g. rollup, and that commit has never been published to NPM. Several commits/PRs for smaller bugs are also still pending.

Unfortunately, the current policy over at NPM (see discussion) prevents from transferring the ownership of the package on NPM over to an active user. (Or to mark the package as unmaintained/deprecated)

winston-syslog should change its dependency to a maintainable package. There are a couple of existing forks but no guarantee they'll be maintained.
Since most of the dependents on glossy are winston-adjacent, could it make sense to have a @winston/glossy operating fork?

Happy to help with PRs in case such a repo is created.

@DABH
Copy link
Contributor

DABH commented Jan 4, 2024

I've made a fork at @winstonjs/glossy , but waiting to publish to npm under the same name. Someone appears to be squatting the winstonjs org name on npm so I filed a support ticket to claim it. The autoresponse from GitHub/NPM says it could take "up to multiple months" for them to review this support ticket :( So will provide an update here whenever I hear back from them... would definitely appreciate help with PRs (for all the winston dependents) once this is wrapped up...

@ClementValot
Copy link
Author

Hi 👋

I've opened up a first PR for @winstonjs/glossy, mostly formatting. I've left the source code untouched for backwards compatibility, but there are a few syntax improvements (notably var vs let/const, or the deprecated substr) that should be implemented (If someone has a system running on Node 5, upgrading their winston dependency is the least of their problems)

Next steps probably include modernizing the unit tests for readability/maintainability (including using an actual test runner), and once they are secured, we can dive into the functionality and implement some syntax fixes/optimizations/pending fixes

Any news on the publishing front?

@DABH
Copy link
Contributor

DABH commented Mar 2, 2024

I just checked my support ticket, and still no reply from GH/NPM yet. They did say it could take "months" for a reply when I opened the ticket (exactly 2 months ago), so I guess they weren't wrong.

In the meantime, I merged your PR (huge thanks!), so at least the repo is going to get into good shape while we wait for a good name to publish it under 🥲

@ClementValot
Copy link
Author

Hi 👋

It's been a few months now, have you by chance had any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants