Skip to content

Commit 1d897ad

Browse files
Abbas-khaliqsoftvar
authored andcommitted
refactor(sdk): rubocop warnings fixed, code properly linted
1 parent 2ee4975 commit 1d897ad

40 files changed

+2017
-2170
lines changed

.rubocop.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,15 @@ Metrics/AbcSize:
1010
Max: 100
1111
Metrics/ParameterLists:
1212
Max: 10
13+
MaxOptionalParameters: 5
1314
Metrics/CyclomaticComplexity:
1415
Max: 30
1516
Metrics/PerceivedComplexity:
1617
Max: 30
18+
Metrics/ModuleLength:
19+
Max: 225
20+
Style/RedundantBegin:
21+
Enabled: false
1722
Style/Documentation:
1823
Enabled: false
1924
Style/ZeroLengthPredicate:
@@ -30,3 +35,11 @@ Style/MutableConstant:
3035
Enabled: false
3136
Style/FrozenStringLiteralComment:
3237
Enabled: false
38+
Style/OptionalBooleanParameter:
39+
AllowedMethods: ['initialize', 'get_variation_if_whitelisting_passed', 'whitelisting_or_storage_for_grouped_campaigns?', 'presegmentation?', 'get_variation_allotted', 'save_user_storage', 'get_stored_variation', 'get_variation_of_campaign_for_user', 'get_user_storage', 'evaluate_whitelisting', 'flush', 'log', 'generator_for', 'evaluate', 'get_settings_file', 'user_part_of_campaign?', 'bucket_user_to_variation', 'get_bucket_value_for_user']
40+
Style/DoubleNegation:
41+
Enabled: false
42+
Style/CombinableLoops:
43+
Enabled: false
44+
Security/JSONLoad:
45+
Enabled: false

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,16 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## [1.37.1] - 2022-25-04
8+
9+
### Changed
10+
11+
- Code properly linted, fixed rubocop warnings and errors
12+
713
## [1.36.0] - 2022-04-04
814

15+
### Changed
16+
917
- Fix resolving `vwo_sdk_log_messages` dependency
1018

1119
## [1.35.0] - 2022-03-28

Gemfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ source 'http://rubygems.org'
22

33
gem 'json-schema', '~>2.8.1'
44
gem 'murmurhash3', '~>0.1.6'
5-
gem "vwo_log_messages", '~>0.7.4'
5+
gem 'vwo_log_messages', '~>0.7.4'
66

77
# gem 'codecov', require: false, group: 'test'
8-
# gem 'rubocop', require: false, group: 'test'
8+
gem 'rubocop', require: false, group: 'test'
99

1010
group :development, :test do
1111
gem 'mocha', '~> 1.13'

0 commit comments

Comments
 (0)