Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@iconify/json included by default, adding ~40mb to the download #679

Open
jeremyjacob opened this issue Sep 28, 2022 · 0 comments
Open

@iconify/json included by default, adding ~40mb to the download #679

jeremyjacob opened this issue Sep 28, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
next

Comments

@jeremyjacob
Copy link

jeremyjacob commented Sep 28, 2022 •
edited
Loading

Describe the bug

The package @iconify/json is included in the devDependancies, which I gather to be an experimental feature. Looks cool, but this forces users of this package to download about 40 megs of JSON definition files, just to import a type. Consider re-typing this definition manually to avoid the large dependency.

System Info

NA

Used Package Manager

pnpm
@jeremyjacob jeremyjacob added bug Something isn't working pending triage labels Sep 28, 2022
@alexanderniebuhr alexanderniebuhr added enhancement New feature or request good first issue Good for newcomers and removed bug Something isn't working pending triage labels Sep 28, 2022
@alexanderniebuhr alexanderniebuhr added this to the next milestone Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
next
Development

No branches or pull requests
2 participants
@jeremyjacob @alexanderniebuhr