You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If it helps, here is the local freeshow update file I use. It should probably get a review from someone else before a PR is created. (...Or maybe the PR process is how a review happens?)
DEFVER=1 ARCHS_SUPPORTED="amd64 arm64" get_github_releases "ChurchApps/FreeShow" "latest" if [ "${ACTION}" != prettylist ]; then URL="$(grep "browser_download_url.*${HOST_ARCH}\.deb\"" "${CACHE_FILE}" | head -n1 | cut -d'"' -f4)" VERSION_PUBLISHED="$(echo "${URL}" | cut -d'-' -f2)" fi PRETTY_NAME="FreeShow" WEBSITE="https://freeshow.app/" SUMMARY="A free and open-source presenter"
A PR is the best place for review especially if you have a working definition that could be merged. Just a quick suggestion (which a maintainer could make more easily and even commit for you in a PR context): take a look at the changes in #1253, which tweak the template to include the improvements that have been widely applied to
replace a lot of | head -n1 | calls by adding -m 1 to the preceeding grep
remove a lot of unnecessary echo calls by input redirection
The text was updated successfully, but these errors were encountered: