Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about k-mer frequency #18

Open
XiaomingXu1995 opened this issue Oct 25, 2020 · 3 comments
Open

question about k-mer frequency #18

XiaomingXu1995 opened this issue Oct 25, 2020 · 3 comments
Assignees

Comments

@XiaomingXu1995
Copy link

dear will-rowe,
HULK is concerned about the k-mer frequency as described in your paper. I find that a minimizer hash value cannot be added into the minimizerSketch when it is contained in the sketch(minimizer.go, line 195). So the hash values in the minimizerSketch are unique. We cannot add the same minimizer hash value into the minimizerSketch inside a window, but if two different windows have the same minimizer-kmer, shall we concern the k-mer frequency?

@will-rowe
Copy link
Owner

Hi @XiaomingXu1995 - you are right that only unique minimizers are added to a sketch for a read. It would be a good idea to take into account minimizer frequency, I should probably try that.

I'm afraid HULK has been neglected recently. I will do my best to get back to it and try some new ideas out, including your observation. Thank you for your interest in it.

@will-rowe will-rowe self-assigned this Nov 3, 2020
@jianshu93
Copy link

Any update on this?

Thanks,

Jianshu

@will-rowe
Copy link
Owner

Hi Jianshu,

I'm afraid that I'm pushed for time at the moment and am unlikely to get to this anytime soon.

Will

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants