Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after refresh #2

Open
Surgeonito opened this issue Sep 17, 2018 · 1 comment
Open

after refresh #2

Surgeonito opened this issue Sep 17, 2018 · 1 comment

Comments

@Surgeonito
Copy link

There is a case when the plugin is not working properly.

When user A saves and after his admin edit panel is fully refreshed and THEN user B updates - all is ok.

But when two users are editing the post and both of them will press 'Update' at the same time - one of them will get this :
edit post multisite wordpress

user B has taken over and is currently editing.
Your latest changes were saved as a revision.

@Surgeonito
Copy link
Author

I checked the parameters' set send with this heartbeat request and there was no 'fce' field, so the
\Fabrica\CollaborativeEditing\Base::filterHeartbeatResponse method is not doing what it is supposed to do.

Somehow the code
wp.heartbeat.enqueue('fce', { 'post_id' : jQuery('#post_ID').val() }, true);
in \wp-content\plugins\fabrica-collaborative-editing\js\post.js takes no effect.

Surgeonito added a commit to Surgeonito/fabrica-collaborative-editing that referenced this issue Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant