-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added accelerator keys #265
base: master
Are you sure you want to change the base?
Conversation
Hi and thanks! Could you please resolve the errors in the patch? See the list at https://travis-ci.org/github/wikimedia/wikilabels/builds/753930294 - thanks a lot! :) |
I have made the required edits. I also had a question - Do I need to communicate on phabricator to solve issues? or can I do it directly here also by commenting on the issue I want to work on? |
Thanks! That's a good question for the Wikilabels folks (I'm not one of them). :) |
Oh! I am sorry I thought you were with Wikilabels. PS: will the PR be merged? |
I am not. I'm with Wikimedia. :)
In general (applies to any PR in any project): First it needs to be reviewed. If the review is positive, then likely yes. |
Oh, Thanks a lot |
I added the accelerator keys according to T162109