Add-ons localization issues

[hessenfarmer]

although all addons are translated to german the translation is not shown in the Addons screen in current widelands.
This is either a bug in the Github action or in the i18n code

[Noordfrees]

Do you mean the Installed or the Browse tab?
For remotes, it is not possible to show them localized with the current implementation (which is fixed in my addons-webserver branch though).

[frankystone]

The localized strings might only be applied if one restarts widelands.

Currently i have updated some addons and i saw localization files are downloaded, but the localization was shown only after restarting widelands. Not sure if reentering the Addons (by quitting the addons window and reopen it again) does also do the trick.

[Noordfrees]

I cannot reproduce that, for me the name and description are show in the Installed tab correctly in Low German immediately after the download completed…

[frankystone]

Just to be precise: The observation i made was for already downloaded addons. Thats why i talked about upgrading an addon which was already installed. In the tab 'installed' i have clicked 'Update all' but the localization was not applied immediately.

Let's wait for @hessenfarmer's response.

[Noordfrees]

Sorry seems I had overread that. So the add-on's localized description is currently FOO, then you do an upgrade that changes the localized description to BAR (while not changing the unlocalized description), and the info in the installed tab keeps showing FOO?
I know gettext does some caching of translated strings, to improve performance, so this is not really a bug in Widelands. But I'll check whether there exists some magic to reset this cache after an upgrade to fix this glitch.

[hessenfarmer]

I meant the Browse tab and I was confused as some Part are localized there e.g."Diese Erweiterung ist bekannt Abstürze zu verursachen. If this is normal then this is not a bug.

[hessenfarmer]

I just downloaded the 2 mapsets (challenge and former official) the localization is shon in the addons manager however the maps are not translated when strting a game

[Noordfrees]

I meant the Browse tab and I was confused as some Part are localized there e.g."Diese Erweiterung ist bekannt Abstürze zu verursachen. If this is normal then this is not a bug.

Name, description and author are currently never localized in the Browse tab. Everything else is. So all fine here.

I just downloaded the 2 mapsets (challenge and former official) the localization is shon in the addons manager however the maps are not translated when strting a game

Confirmed, that seems to be a general bug, will fix

[hessenfarmer]

maybe a picture shows it better
this can be found in the browse tab of remote addons

[Noordfrees]

So I summarize the several different glitches which this bug report is about:

• Missing localization of map names in map select screens (applies also to scenario select screen): fixed in Fix textdomains for add-on maps widelands#4743
• Possibility to localize directory names in map sets: fixed in Fix textdomains for add-on maps widelands#4743
• Missing localization of the map name in the Load Game window and the MP setup screen if the game was played on an add-on map: Not trivial to solve, because we'll need to store the name of the add-on defining the map in the savegame. I'm in favour of postponing fixing this to post-1.0.
• Partly missing localization in the Browse tab: Will be fixed by https://github.com/Noordfrees/widelands/tree/addons-webserver (post-1.0)
• Translation changes not getting applied after an upgrade: will be fixed by Use shared_ptr for AddOnInfo widelands#4747 (post-1.0)