From b4595cc68cf70cb60631d3a691fa75473d68ca89 Mon Sep 17 00:00:00 2001 From: Francois Buys Date: Mon, 2 Oct 2023 20:51:44 +0200 Subject: [PATCH] ISSUE-462: Add rexml dependency for Ruby 3.0.0+ We add rexml as a runtime dependency for environments that make use of Ruby 3 and up See: https://stackoverflow.com/a/65480744 Issue: https://github.com/whitesmith/rubycritic/issues/462 --- CHANGELOG.md | 2 ++ rubycritic.gemspec | 1 + 2 files changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 529eb58d..ee2bd9b0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ * [CHANGE] Fix test warning related to `cucumber_opts` declaration (by [@faisal][]) * [BUGFIX] Stop using long-deprecated MiniTest module name, removed in 5.19.0 (by [@faisal][]) * [CHANGE] Disable VERBOSE warnings in test stubs (by [@fbuys][]) +* [CHANGE] Add rexml dependency for Ruby 3.0.0+ support (by [@fbuys][]) # v4.8.1 / 2023-05-17 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.8.0...v4.8.1) @@ -433,3 +434,4 @@ [@faisal]: https://github.com/faisal [@96RadhikaJadhav]: https://github.com/96RadhikaJadhav [@Fito]: https://github.com/Fito +[@fbuys]: https://github.com/fbuys diff --git a/rubycritic.gemspec b/rubycritic.gemspec index b0ab1287..93dec225 100644 --- a/rubycritic.gemspec +++ b/rubycritic.gemspec @@ -36,6 +36,7 @@ Gem::Specification.new do |spec| spec.add_runtime_dependency 'parser', '>= 3.2.2.1' spec.add_runtime_dependency 'rainbow', '~> 3.1.1' spec.add_runtime_dependency 'reek', '~> 6.0', '< 7.0' + spec.add_runtime_dependency 'rexml' spec.add_runtime_dependency 'ruby_parser', '~> 3.20' spec.add_runtime_dependency 'simplecov', '>= 0.22.0' spec.add_runtime_dependency 'tty-which', '~> 0.5.0'