Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubycritic support for Ruby 3.2.2 #462

Closed
joaoleal93 opened this issue Jul 28, 2023 · 4 comments · Fixed by #472
Closed

Rubycritic support for Ruby 3.2.2 #462

joaoleal93 opened this issue Jul 28, 2023 · 4 comments · Fixed by #472

Comments

@joaoleal93
Copy link

No description provided.

@faisal
Copy link
Contributor

faisal commented Sep 26, 2023

What is the issue here?

@joaoleal93
Copy link
Author

Hi, i am having a problem using ruby critic for ruby version 3.2.2

image

@fbuys
Copy link
Collaborator

fbuys commented Oct 2, 2023

I'll take a look at this one.

fbuys added a commit to fbuys/rubycritic that referenced this issue Oct 2, 2023
Added a ruby_version variable to rubycritic.gemspec, this variable can
be used to conditionally add dependencies.

We add rexml as a runtime dependency for environments that make use of
Ruby 3 and up

See: https://stackoverflow.com/a/65480744
Issue: whitesmith#462
fbuys added a commit to fbuys/rubycritic that referenced this issue Oct 2, 2023
Added a ruby_version variable to rubycritic.gemspec, this variable can
be used to conditionally add dependencies.

We add rexml as a runtime dependency for environments that make use of
Ruby 3 and up

See: https://stackoverflow.com/a/65480744
Issue: whitesmith#462
@fbuys
Copy link
Collaborator

fbuys commented Oct 2, 2023

I have added a PR for this request: #467

fbuys added a commit to fbuys/rubycritic that referenced this issue Oct 5, 2023
Added a ruby_version variable to rubycritic.gemspec, this variable can
be used to conditionally add dependencies.

We add rexml as a runtime dependency for environments that make use of
Ruby 3 and up

See: https://stackoverflow.com/a/65480744
Issue: whitesmith#462
fbuys added a commit to fbuys/rubycritic that referenced this issue Oct 5, 2023
Added a ruby_version variable to rubycritic.gemspec, this variable can
be used to conditionally add dependencies.

We add rexml as a runtime dependency for environments that make use of
Ruby 3 and up

See: https://stackoverflow.com/a/65480744
Issue: whitesmith#462
fbuys added a commit to fbuys/rubycritic that referenced this issue Oct 5, 2023
Added a ruby_version variable to rubycritic.gemspec, this variable can
be used to conditionally add dependencies.

We add rexml as a runtime dependency for environments that make use of
Ruby 3 and up

See: https://stackoverflow.com/a/65480744
Issue: whitesmith#462
fbuys added a commit to fbuys/rubycritic that referenced this issue Oct 5, 2023
We add rexml as a runtime dependency for environments that make use of
Ruby 3 and up

See: https://stackoverflow.com/a/65480744
Issue: whitesmith#462
etagwerker added a commit that referenced this issue Oct 17, 2023
We add rexml as a runtime dependency for environments that make use of
Ruby 3 and up

See: https://stackoverflow.com/a/65480744
Issue: #462

Co-authored-by: Ernesto Tagwerker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants