Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having a list of recommended components #1

Open
Utzel-Butzel opened this issue Sep 20, 2017 · 7 comments
Open

Having a list of recommended components #1

Utzel-Butzel opened this issue Sep 20, 2017 · 7 comments

Comments

@Utzel-Butzel
Copy link
Collaborator

We just had a call with Laura and Maurizio, and our idea was to have list of reusable packages, where we only provide the related css.

My recommendation for these components would be:

Shall we have some prefered libraries for common components like tooltips, tables, etc.?

@laurasilvani
Copy link

Thanks Robert for sharing this list. The goal is to have a set of libraries that should be used in our React apps whenever needed and they should be preferred over other libraries. When using some other libraries, for some other reasons, we must align their styling to our look and feel to ensure visual consistency.
I am adding to the list:

@laurasilvani
Copy link

Regarding React Table library, the styling of the table itself is a piece of cake, while the pagination has to be rewritten with a custom component to be in line with the UI Kit look & file.

@redmoonlas
Copy link
Collaborator

Ok, but if we have a backend pagination management (and it always should be for performance reasons on a big items list) we will handle it with a separate component and leave to the table component only the responsibility of render a single page of items.

@Utzel-Butzel
Copy link
Collaborator Author

Utzel-Butzel commented Sep 27, 2017

@laurasilvani I have a datatable.scss, which is based on the standard react-table styling to adapt the WFP UI Kit look and feel.
@redmoonlas Yes, using server side data pagination management with react-table works nicely.
https://react-table.js.org/#/story/server-side-data

@laurasilvani
Copy link

@Utzel-Butzel That is great, but the React Table pagination is missing the page counting, as it is in the kit http://cdn.wfp.org/guides/ui/v0.14.0/components/navigation/#pagination. As far as I know there are no options available right now other than making our custom component. The Next and Previous buttons are easily customisable.

@princylunawat
Copy link
Collaborator

@Utzel-Butzel i have already used the datatable.scss in the current library. i am still missing the column-width adjustment when putting the table in an outer container. You can see it deployed as-is on http://pydev.wfp.org:8311/. Any suggestions on how to fix?

I suggest we make further changes to datatable.scss to meet any remaining guidelines and including the pagination component as well.

@laurasilvani
Copy link

UI Elements & Projects.xlsx
Here is a list of React elements used by the three React projects in WFP right now, recently updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants