fix: process hang due to theme source endless loop (#469)

Author: sentialx

src/main/models/settings.ts

@@ -73,15 +73,18 @@ export class Settings extends EventEmitter {
   };
 
   public update = () => {
+    let themeSource = 'system';
+
     if (this.object.themeAuto) {
       this.object.theme = nativeTheme.shouldUseDarkColors
         ? 'wexond-dark'
         : 'wexond-light';
-
-      nativeTheme.themeSource = 'system';
     } else {
-      nativeTheme.themeSource =
-        this.object.theme === 'wexond-dark' ? 'dark' : 'light';
+      themeSource = this.object.theme === 'wexond-dark' ? 'dark' : 'light';
+    }
+
+    if (themeSource !== nativeTheme.themeSource) {
+      nativeTheme.themeSource = themeSource as any;
     }
 
     Application.instance.dialogs.sendToAll('update-settings', this.object);

src/main/services/dialogs-service.ts

@@ -305,7 +305,9 @@ export class DialogsService {
   };
 
   public sendToAll = (channel: string, ...args: any[]) => {
-    this.getBrowserViews().forEach((x) => x.webContents.send(channel, ...args));
+    this.getBrowserViews().forEach(
+      (x) => !x.isDestroyed() && x.webContents.send(channel, ...args),
+    );
   };
 
   public get(name: string) {

src/main/view.ts

@@ -200,7 +200,7 @@ export class View {
           this.emitEvent('favicon-updated', fav);
         } catch (e) {
           this.favicon = '';
-          console.error(e);
+          // console.error(e);
         }
       },
     );