Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass client to waitForTransactionReceipt #3929

Closed
wants to merge 1 commit into from
Closed

pass client to waitForTransactionReceipt #3929

wants to merge 1 commit into from

Conversation

benschac
Copy link
Contributor

@benschac benschac commented May 14, 2024 •
edited
Loading

Description

Looking into waitForTransactionReceipt this seems like a no-op.

Notes

  • snapshot tests were failing when initial clone of repo was pulled. I can update them in another PR.
  • this is my first real PR here. Forgive me if there's any large gap in context I might be missing.

fixes: #3635

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: 75c1bfc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

benschac
benschac commented May 14, 2024
View reviewed changes
playgrounds/vite-react/src/App.tsx
@@ -138,7 +140,7 @@ function SwitchChain() {
<button
disabled={chainId === chain.id}
key={chain.id}
onClick={() => switchChain({ chainId: chain.id })}
onClick={() => switchChain({ chainId: chain.id as ChainIds })}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

un-related. Saw an error, fixed an error.

benschac
benschac commented May 14, 2024
View reviewed changes
playgrounds/vite-react/src/App.tsx
Comment on lines +264 to +270
config: {
...config,
// Additionally, we can pass a client to the config
// to use a different client than the one passed to the hook
client,
},
chainId: connectorClientData?.chain?.id,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this will help someone in the future when they run into / search this issue.

@vercel Vercel
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 5:19pm

@benschac benschac marked this pull request as ready for review May 14, 2024 17:42
@tmm tmm force-pushed the main branch 12 times, most recently from 40a89db to 6dc1d22 Compare May 23, 2024 14:52
@tmm
Copy link
Member

tmm commented Jun 11, 2024

Thanks for this! Think I'm going to take this on since there seems to be a larger internal types refactor.

@tmm tmm closed this Jun 11, 2024
@ibrosen ibrosen mentioned this pull request Jun 17, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: waitForTransactionReceipt doesn't accept client with multiple possible chains
2 participants
@benschac @tmm