Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: up changeset #3029

Merged
merged 1 commit into from
Nov 20, 2024
Merged

chore: up changeset #3029

merged 1 commit into from
Nov 20, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Nov 20, 2024


PR-Codex overview

This PR focuses on enhancing the security of the signature generation process, addressing issue #3028.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: c313b0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
viem Minor

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem 🔄 Building (Inspect) Visit Preview Nov 20, 2024 0:40am

@jxom jxom merged commit 87f18bc into main Nov 20, 2024
4 of 5 checks passed
@jxom jxom deleted the jxom-patch-1 branch November 20, 2024 00:41
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (8821e73) to head (c313b0f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3029      +/-   ##
==========================================
- Coverage   99.65%   99.64%   -0.02%     
==========================================
  Files         856      856              
  Lines       70521    70521              
  Branches     3131     3127       -4     
==========================================
- Hits        70280    70271       -9     
- Misses        224      233       +9     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
import * from 'viem' (esm) 62.15 KB (0%) 1.3 s (0%) 500 ms (-2.89% 🔽) 1.8 s
const viem = require('viem') (cjs) 72.32 KB (0%) 1.5 s (0%) 1.2 s (-17.4% 🔽) 2.6 s
import { createClient, http } from 'viem' 6.32 KB (0%) 127 ms (0%) 34 ms (-35.5% 🔽) 160 ms
import * from 'viem/account-abstraction' 45.33 KB (0%) 907 ms (0%) 293 ms (-57.02% 🔽) 1.2 s
import { toCoinbaseSmartAccount } from 'viem/account-abstraction' 35.28 KB (0%) 706 ms (0%) 484 ms (+146.76% 🔺) 1.2 s
import * from 'viem/accounts' 81.05 KB (0%) 1.7 s (0%) 580 ms (+120.59% 🔺) 2.3 s
import { privateKeyToAccount } from 'viem/accounts' 20.42 KB (0%) 409 ms (0%) 186 ms (-49.86% 🔽) 594 ms
import { mnemonicToAccount } from 'viem/accounts' 26.02 KB (0%) 521 ms (0%) 143 ms (-50.77% 🔽) 663 ms
import * from 'viem/actions' 47.33 KB (0%) 947 ms (0%) 561 ms (-3.5% 🔽) 1.6 s
import { getBlockNumber } from 'viem/actions' 318 B (0%) 10 ms (0%) 4 ms (+80.54% 🔺) 14 ms
import * from 'viem/chains' 39.13 KB (0%) 783 ms (0%) 260 ms (-29.65% 🔽) 1.1 s
import { mainnet } from 'viem/chains' 324 B (0%) 10 ms (0%) 22 ms (+532.18% 🔺) 32 ms
import * from 'viem/chains/utils' 1.08 KB (0%) 22 ms (0%) 4 ms (+10.81% 🔺) 26 ms
import * from 'viem/ens' 47.07 KB (0%) 942 ms (0%) 217 ms (-21.51% 🔽) 1.2 s
import { getEnsAvatar } from 'viem/ens' 22.19 KB (0%) 444 ms (0%) 546 ms (+85.7% 🔺) 990 ms
import * from 'viem/siwe' 31.09 KB (0%) 622 ms (0%) 508 ms (-9.58% 🔽) 1.2 s
import { verifySiweMessage } from 'viem/siwe' 30.11 KB (0%) 603 ms (0%) 713 ms (+288.09% 🔺) 1.4 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant