Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomSource.signMessage has incorrect output type #2562

Closed
1 task done
matthiasgeihs opened this issue Jul 30, 2024 · 2 comments
Closed
1 task done

CustomSource.signMessage has incorrect output type #2562

matthiasgeihs opened this issue Jul 30, 2024 · 2 comments
Labels
Good First Issue Misc: Good First Issue

Comments

@matthiasgeihs
Copy link

Check existing issues

Viem Version

2.18.5

Current Behavior

Output type of CustomSource.signMessage is Hash. This is most likely incorrect because this outputs a signature which is not a hash.

signMessage: ({ message }: { message: SignableMessage }) => Promise<Hash>

Expected Behavior

Output type of CustomSource.signMessage should probably be Hex, as defined in actions/wallet/signMessage.ts.

export type SignMessageReturnType = Hex

Steps To Reproduce

No response

Link to Minimal Reproducible Example

No response

Anything else?

This is just a minor nitpick, but was confusing me for a bit, so I think fixing would be nice.

@tmm tmm added the Good First Issue Misc: Good First Issue label Jul 30, 2024
@jxom
Copy link
Member

jxom commented Jul 30, 2024

Fixed.

@jxom jxom closed this as completed Jul 30, 2024
Copy link
Contributor

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Viem version. If you have any questions or comments you can create a new discussion thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good First Issue Misc: Good First Issue
Projects
None yet
Development

No branches or pull requests

3 participants