Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Government of Canada Intranet theme: h1 for #WBCont #100

Open
Tradewagon opened this issue Aug 19, 2014 · 6 comments
Open

Government of Canada Intranet theme: h1 for #WBCont #100

Tradewagon opened this issue Aug 19, 2014 · 6 comments

Comments

@Tradewagon
Copy link

I think you are missing the resize on the top margin of h1 for #WBCont in theme.css. Check your internet theme and you will see that you have resized it but not in Intranet.

Rich

@pjackson28
Copy link
Member

@Tradewagon Could you please post screenshots identifying the issue? I tried comparing the the two themes at various viewport sizes and didn't notice a difference. Perhaps I'm misunderstanding the issue so the visuals would help.

@Tradewagon
Copy link
Author

Here you go... Check out the "Home" heading and on the Internet one and you can see the theme.min alters the top margin whereas there is no change from the intranet version from theme.min.

internetheadingwiththemespacev404
intranetheadingwithbigspacev404

@Tradewagon
Copy link
Author

as an additional comment ... on your example site,you can see it as well - unless the large space is intentional

image

@pjackson28
Copy link
Member

@Tradewagon Turns out the error was in the GC Web Usability theme. It incorrectly had a 20px override for the margin-top of the h1. The margin-top has been corrected in that theme.

@Tradewagon
Copy link
Author

okies... so we want a big white space?

@pjackson28
Copy link
Member

@Tradewagon It's the same top margin that was requested for Canada.ca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants