To fix "ESC only works if a line is selected" in Save Gumps

Dragon-Baroque · Dragon-Baroque · commit 0db1d4dc4ffb · 2025-04-09T22:39:02.000+02:00
gumps/File_gump.cc + Newfile_gump.cc
    In character_input, return false not true to notify Gump_manager
      that character_input has not been handled
diff --git a/gumps/File_gump.cc b/gumps/File_gump.cc
@@ -606,7 +606,7 @@ bool File_gump::mouse_up(
 bool File_gump::character_input(int chr, int unicode, bool shift_pressed) {
 	ignore_unused_variable_warning(unicode);
 	if (!focus) {    // Text field?
-		return true;
+		return false;
 	}
 	switch (chr) {
 	case SDLK_RETURN:    // If only 'Save', do it.
diff --git a/gumps/Newfile_gump.cc b/gumps/Newfile_gump.cc
@@ -817,7 +817,7 @@ bool Newfile_gump::character_input(int chr, int unicode, bool shift_pressed) {
 
 	// Are we selected on some text?
 	if (selected == -3) {
-		return true;
+		return false;
 	}
 
 	switch (chr) {

Original file line number	Diff line number	Diff line change
`@@ -606,7 +606,7 @@ bool File_gump::mouse_up(`
`606`	`606`	`bool File_gump::character_input(int chr, int unicode, bool shift_pressed) {`
`607`	`607`	`ignore_unused_variable_warning(unicode);`
`608`	`608`	`if (!focus) { // Text field?`
`609`		`- return true;`
	`609`	`+ return false;`
`610`	`610`	`}`
`611`	`611`	`switch (chr) {`
`612`	`612`	`case SDLK_RETURN: // If only 'Save', do it.`
Original file line number	Diff line number	Diff line change
`@@ -817,7 +817,7 @@ bool Newfile_gump::character_input(int chr, int unicode, bool shift_pressed) {`
`817`	`817`
`818`	`818`	`// Are we selected on some text?`
`819`	`819`	`if (selected == -3) {`
`820`		`- return true;`
	`820`	`+ return false;`
`821`	`821`	`}`
`822`	`822`
`823`	`823`	`switch (chr) {`