You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am not sure it is reasonable that the Avatar UI on the profile page is on the very top, somewhat hackishly implemented via the all_admin_noticeshook. show_user_profile and edit_user_profile might be more reasonable choices.
Good news: Just switching the hook to one of these two works flawlessly. Once #26 is done this might be an easy fix.
The text was updated successfully, but these errors were encountered:
Okay I take that "flawlessly" back because using one of those other hooks ends up with nested <form> tags. Maybe this was the reason it was done like this in the first place.
@kraftner Yes, that was the reason – which I forgot, but now that you mention it …
Maybe a quick PR with a note for the README? Documenting "design decisions" in the form of a note to our later selfs might not be too stupid. Helped me in some cases with other projects.
I am not sure it is reasonable that the Avatar UI on the profile page is on the very top, somewhat hackishly implemented via the
all_admin_notices
hook.show_user_profile
andedit_user_profile
might be more reasonable choices.Good news: Just switching the hook to one of these two works flawlessly. Once #26 is done this might be an easy fix.
The text was updated successfully, but these errors were encountered: