-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: tweak style for overlay #4576
refactor: tweak style for overlay #4576
Conversation
Right now I think the style improvement is not substantial. I'll add examples that use Created this MR in case there is feedback. |
Codecov ReportBase: 92.06% // Head: 92.06% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #4576 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 16 16
Lines 1639 1639
Branches 617 617
=======================================
Hits 1509 1509
Misses 119 119
Partials 11 11 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
9197ef6
to
0313243
Compare
I find out that Should I add this in as well or it's better that I implement it in another PR? |
0313243
to
3c56cfa
Compare
@malcolm-kee Let's do it in another PR, can you update tests? Thank you for the PR |
1c70f5f
to
868b249
Compare
@malcolm-kee you may have to update the snapshots for webpack v4 as well. |
868b249
to
e26dd6a
Compare
e26dd6a
to
922c482
Compare
Thank you, feel free to send more PRs which will improve overlay |
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Tweak the styles for overlay.
Before
After
Breaking Changes
Additional Info
This is to partially resolves #3689