Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tweak style for overlay #4576

Merged

Conversation

malcolm-kee
Copy link
Contributor

@malcolm-kee malcolm-kee commented Sep 20, 2022

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Tweak the styles for overlay.

Before

image

After

after

image

Breaking Changes

Additional Info

This is to partially resolves #3689

@malcolm-kee
Copy link
Contributor Author

Right now I think the style improvement is not substantial. I'll add examples that use ts-loader as that print out some code snippet and iterate more.

Created this MR in case there is feedback.

@malcolm-kee malcolm-kee marked this pull request as draft September 20, 2022 12:00
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 92.06% // Head: 92.06% // No change to project coverage 👍

Coverage data is based on head (922c482) compared to base (d440baf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4576   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files          16       16           
  Lines        1639     1639           
  Branches      617      617           
=======================================
  Hits         1509     1509           
  Misses        119      119           
  Partials       11       11           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@malcolm-kee
Copy link
Contributor Author

I find out that react-error-overlay has extra logic to open file with error if the filename and line of code can be detected using this middleware.

Should I add this in as well or it's better that I implement it in another PR?

@malcolm-kee malcolm-kee marked this pull request as ready for review September 21, 2022 08:08
@alexander-akait
Copy link
Member

@malcolm-kee Let's do it in another PR, can you update tests? Thank you for the PR

@malcolm-kee malcolm-kee force-pushed the feat/improve-overlay-style branch 2 times, most recently from 1c70f5f to 868b249 Compare September 24, 2022 11:39
@snitin315
Copy link
Member

snitin315 commented Sep 25, 2022

@malcolm-kee you may have to update the snapshots for webpack v4 as well.

@alexander-akait alexander-akait merged commit 791fb85 into webpack:master Sep 26, 2022
@alexander-akait
Copy link
Member

Thank you, feel free to send more PRs which will improve overlay

@malcolm-kee malcolm-kee deleted the feat/improve-overlay-style branch May 11, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve our overlay
3 participants