-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-use current tab instead of open a new one #1400
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@elrumordelaluz yes, here issue webpack/webpack.js.org#2069 |
Just in case somebody else stumbles upon this ticket and wonders "should I use webpack-serve"?
|
feel free to send a PR |
Just as a reference, @elrumordelaluz submitted a PR to Since it's much more involved than I thought it would be I am not sure it's simply to copy it over to |
@flekschas feel free to send a PR |
Oh we don't have event/hooks right now, we need implement their |
Would it be possible for the |
vue-cli does this pretty well! |
@atilkan PR welcome if you have idea how to implement it |
I have an idea for a more cross platform solution - we could add a shortcut (R - reload) for restart webpack from terminal. Similar to how it works in jest - by press R webpack restarting and refresh the already opened page. |
mark |
There is a holdover solution for people waiting on this feature to be implemented into webpack-dev-server. The way create-react-app does it is with a react-dev-utils script called openBrowser. Importing this function into a webpack
With one other caveat, the .applescript file needs to be copied into the root of your project. Information about that script and where to find these files here: https://stackoverflow.com/questions/48913566/how-does-create-react-app-re-use-an-existing-browser-tab-after-running-npm-run/48915952 |
@Kaspar78 it's work only for mac platform |
fixed it |
It seems to only apply to the mac platform, and create-react-app does the same: https://github.com/facebook/create-react-app/blob/25184c4e91ebabd16fe1cde3d8630830e4a36a01/packages/react-dev-utils/openBrowser.js#L65-L86 |
Yes PR welcome |
Hey,I fount it work for me in webpack 5 like this: // you could install react-dev-utils
import openBrowser from "react-dev-utils/openBrowser";
// webpack devServer config
{
devServer: {
host: '0.0.0.0',
port: 8080,
hot: false,
onListening: function (devServer) {
if (!devServer) {
throw new Error('webpack-dev-server is not defined');
}
const addr = devServer.server.address();
openBrowser(`http://${addr.address}:${addr.port}`);
},
}
} good luck |
is the issue closed? |
No |
Code
// webpack.config.js
// additional code, remove if not needed.
Expected Behavior
Try to refresh the current browser window
Actual Behavior
Open always a new tab
For Bugs; How can we reproduce the behavior?
For Features; What is the motivation and/or use-case for the feature?
Inspired on
create-react-app
solution.Since I usually use Google Chrome, I expect to stay in the same (current) browser tab
when re-launch
webpack-dev-server
, instead of use a new one and close those more.Just curious if the Webpack people/ecosystem are interested in having this behaviour (will PR in case), since is very specific to Chrome browser in OSX platform.
Furthermore, the solution requires to have an extra file
.applescript
in the package.Thoughts?
related #1185
The text was updated successfully, but these errors were encountered: