-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comply with graphql-over-http specification #1206
Comments
Hey @spawnia. Someone has mentioned before that we could just use Could you take a look to see if this is even remotely what you had in mind? It's messy, but enough to show the idea. The test suite is in JS, so I thought simply running a real HTTP server is our best bet here. If this looks alright to you, I can clean it up, add GH actions and, of course, work on the spec compliance. I believe I have a good understanding of the spec, plus there are 60 tests (only 20 of which pass with the current implementation) that cover just about everything. What do you think? |
Of course that can be moved out of |
I have already attempted to add compliance automation for a GraphQL server implementation that sits on top of this library, see nuwave/lighthouse#2359. I wanted to use Deno due to its leaner setup, but progress on it is currently blocked due to graphql/graphql-http#65. If you can implement something similar for this library, I am all for it. Your branch seems to be using Node, that is also fine with me. |
It would be great if the standard server were compliant with the GraphQL-over-HTTP specification.
The test suite could be done in a way that is reusable by other servers: graphql/graphql-over-http#57
The text was updated successfully, but these errors were encountered: