Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InputNew]: Minor bug #1032

Open
AbhinavMV opened this issue Feb 10, 2023 · 3 comments
Open

[InputNew]: Minor bug #1032

AbhinavMV opened this issue Feb 10, 2023 · 3 comments
Assignees
Labels
bug Something isn't working in-review PR is open

Comments

@AbhinavMV
Copy link
Collaborator

only happens when id is not given to the input
when multiple inputs are present on same form , clicking on bottom inputs label focuses on the first input

Reason: by default id is undefined and so all inputs have same id, and since label has htmlFor=id , the first input is focused

Solution: give a unique id to each input as default or make id field as mandatory (making field mandatory will be breaking change so discuss before adding it)

Screen.Recording.2023-02-10.at.5.45.53.PM.mov
@AbhinavMV AbhinavMV added bug Something isn't working help wanted Extra attention is needed ready for dev this issue is ready to be picked up labels Feb 10, 2023
@BillyG83
Copy link
Contributor

mandatory sounds like a good idea to me. TS complier will find it and JS users wont care anyway

@AbhinavMV
Copy link
Collaborator Author

yeah sounds good to me but it means whenever this is fixed we have to fix everything in admin too

@BillyG83
Copy link
Contributor

@AbhinavMV do you guys have a build command. I think it would pick them all up and make a list for you guys. Yeah we should be more careful i think everyone got into a habit of making almost all props optional 😅

@BillyG83 BillyG83 added in-review PR is open and removed help wanted Extra attention is needed ready for dev this issue is ready to be picked up labels Feb 26, 2023
@BillyG83 BillyG83 self-assigned this Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in-review PR is open
Projects
None yet
Development

No branches or pull requests

2 participants