You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
In for example HeaderPickProps, the closeIcon type is string, however this gets eventually passed to Appbar.Action's icon property which has the type IconSource.
Describe the solution you'd like
I wish the icon properties in react-native-paper-dates would also be typed as IconSource rather than string, to match react-native-paper's type.
Describe alternatives you've considered
Currently I'm just casting my IconSource generator method to a string, knowing it all works out.
The text was updated successfully, but these errors were encountered:
MikkoSteerpath
changed the title
Icon typing doesn't match react-native-papers underlying type
Icon typing doesn't match react-native-paper's underlying type
Jul 30, 2024
Hey! Thanks for opening the issue. Can you provide more information about the issue? Please fill the issue template when opening the issue without deleting any section. We need all the information we can, to be able to help. Make sure to at least provide - Current behaviour, Expected behaviour, A way to reproduce the issue with minimal code (link to snack.expo.dev) or a repo on GitHub, and the information about your environment (such as the platform of the device, versions of all the packages etc.).
Hello 👋, this issue has been open for more than a month without a repro or any activity. If the issue is still present in the latest version, please provide a repro or leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution or workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix it.
Is your feature request related to a problem? Please describe.
In for example
HeaderPickProps
, thecloseIcon
type isstring
, however this gets eventually passed to Appbar.Action's icon property which has the typeIconSource
.Describe the solution you'd like
I wish the icon properties in react-native-paper-dates would also be typed as
IconSource
rather than string, to match react-native-paper's type.Describe alternatives you've considered
Currently I'm just casting my IconSource generator method to a string, knowing it all works out.
The text was updated successfully, but these errors were encountered: