Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testharness.js] Cookies can leak between tests when the same WebDriver session is used #48078

Open
jonathan-j-lee opened this issue Sep 10, 2024 · 0 comments
Open

[testharness.js] Cookies can leak between tests when the same WebDriver session is used #48078

jonathan-j-lee opened this issue Sep 10, 2024 · 0 comments
Labels
infra testharness.js wptrunner The automated test runner, commonly called through ./wpt run

Comments

@jonathan-j-lee
Copy link
Contributor

jonathan-j-lee commented Sep 10, 2024 •
edited
Loading

For example, name=value set in

wpt/fetch/api/cors/cors-filtering.sub.any.js

Lines 64 to 67 in 0745979

corsExposeFilter(url, "Set-Cookie", "name=value" , true);
corsExposeFilter(url, "Set-Cookie2", "name=value" , true);
corsExposeFilter(url, "Set-Cookie", "name=value" , true, true);
corsExposeFilter(url, "Set-Cookie2", "name=value" , true, true);

caused cookie counts to be off by one in an unrelated test /fetch/api/credentials/cookies.any.html.

Unfortunately, it seems difficult for wptrunner to enforce a clean slate in all cases because, AIUI, WebDriver's "Delete All Cookies" only deletes cookies applicable to the session's current URL. Thus, "Delete All Cookies" would miss cookies set on domains other than that of the test page, like:

wpt/fedcm/support/fedcm-helper.sub.js

Line 37 in cc83f5a

return set_fedcm_cookie(alt_manifest_origin);

CC @jgraham @WeizhongX
@jonathan-j-lee jonathan-j-lee added infra testharness.js wptrunner The automated test runner, commonly called through ./wpt run labels Sep 10, 2024
jonathan-j-lee added a commit to jonathan-j-lee/wpt that referenced this issue Sep 11, 2024
@jonathan-j-lee
[wptrunner] Clear cookies between testharness tests for Chrome
7a547cb 
Work around web-platform-tests#48078 with CDP [0] in the absence of a robust cross-vendor
solution.

[0]: https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-clearBrowserCookies
@jonathan-j-lee jonathan-j-lee mentioned this issue Sep 11, 2024
Merged
jonathan-j-lee added a commit that referenced this issue Sep 12, 2024
@jonathan-j-lee
[wptrunner] Clear cookies between testharness tests for Chrome (#48106)
199e58f 
Work around #48078 with CDP [0] in the absence of a robust cross-vendor
solution.

[0]: https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-clearBrowserCookies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infra testharness.js wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonathan-j-lee