-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-nesting] Include CSSNestedDeclarations? #697
Comments
Fwiw it's already kind of included since you fixed the parsing tests, so WebKit and gecko are at ninety something percent now. I think it's fine on our end, I plan to implement this change sooner rather than later anyways |
Indeed. But if we don't agree to include CSSNestedDeclarations here, I can remove those tests (from interop, not from WPT), per #604. |
Fine on our side also 👍 |
@andruud I just noticed that some of these tests have a dependency on |
@emilio Oh, my bad. Yes, please move it. |
…smaug I didn't put this behind a pref because it was a bit annoying to do with the parser changes while keeping it fast, and because, at least nesting wise, this is unlikely to cause compat issues. There are some complexities for @scope, which I think I got right. Fixed the tests not to depend on @scope necessarily per the discussion in web-platform-tests/interop#697. Differential Revision: https://phabricator.services.mozilla.com/D222817
I didn't put this behind a pref because it was a bit annoying to do with the parser changes while keeping it fast, and because, at least nesting wise, this is unlikely to cause compat issues. There are some complexities for @scope, which I think I got right. Fixed the tests not to depend on @scope necessarily per the discussion in web-platform-tests/interop#697. Differential Revision: https://phabricator.services.mozilla.com/D222817 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1918408 gecko-commit: 0aa1570bfecae9690855f6d6594e79f59593e36c gecko-reviewers: dshin, webidl, smaug
…smaug I didn't put this behind a pref because it was a bit annoying to do with the parser changes while keeping it fast, and because, at least nesting wise, this is unlikely to cause compat issues. There are some complexities for @scope, which I think I got right. Fixed the tests not to depend on @scope necessarily per the discussion in web-platform-tests/interop#697. Differential Revision: https://phabricator.services.mozilla.com/D222817
…smaug I didn't put this behind a pref because it was a bit annoying to do with the parser changes while keeping it fast, and because, at least nesting wise, this is unlikely to cause compat issues. There are some complexities for @scope, which I think I got right. Fixed the tests not to depend on @scope necessarily per the discussion in web-platform-tests/interop#697. Differential Revision: https://phabricator.services.mozilla.com/D222817
I didn't put this behind a pref because it was a bit annoying to do with the parser changes while keeping it fast, and because, at least nesting wise, this is unlikely to cause compat issues. There are some complexities for @scope, which I think I got right. Fixed the tests not to depend on @scope necessarily per the discussion in web-platform-tests/interop#697. Differential Revision: https://phabricator.services.mozilla.com/D222817 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1918408 gecko-commit: 0aa1570bfecae9690855f6d6594e79f59593e36c gecko-reviewers: dshin, webidl, smaug
…smaug I didn't put this behind a pref because it was a bit annoying to do with the parser changes while keeping it fast, and because, at least nesting wise, this is unlikely to cause compat issues. There are some complexities for scope, which I think I got right. Fixed the tests not to depend on scope necessarily per the discussion in web-platform-tests/interop#697. Differential Revision: https://phabricator.services.mozilla.com/D222817 UltraBlame original commit: 0aa1570bfecae9690855f6d6594e79f59593e36c
…smaug I didn't put this behind a pref because it was a bit annoying to do with the parser changes while keeping it fast, and because, at least nesting wise, this is unlikely to cause compat issues. There are some complexities for scope, which I think I got right. Fixed the tests not to depend on scope necessarily per the discussion in web-platform-tests/interop#697. Differential Revision: https://phabricator.services.mozilla.com/D222817 UltraBlame original commit: 0aa1570bfecae9690855f6d6594e79f59593e36c
…smaug I didn't put this behind a pref because it was a bit annoying to do with the parser changes while keeping it fast, and because, at least nesting wise, this is unlikely to cause compat issues. There are some complexities for @scope, which I think I got right. Fixed the tests not to depend on @scope necessarily per the discussion in web-platform-tests/interop#697. Differential Revision: https://phabricator.services.mozilla.com/D222817
…smaug I didn't put this behind a pref because it was a bit annoying to do with the parser changes while keeping it fast, and because, at least nesting wise, this is unlikely to cause compat issues. There are some complexities for scope, which I think I got right. Fixed the tests not to depend on scope necessarily per the discussion in web-platform-tests/interop#697. Differential Revision: https://phabricator.services.mozilla.com/D222817 UltraBlame original commit: 0aa1570bfecae9690855f6d6594e79f59593e36c
Test List
(Add) css/css-nesting/nested-declarations-cssom.html
(Add) css/css-nesting/nested-declarations-matching.html
Rationale
Possibly a bit late to include in 2024, but checking to see if there's interest anyway. cc @emilio @mdubet
CC'd people already know, but I'll include some examples of potential interop pain anyway:
The implicit rule inside
@media
(color:green
) now matches<div>
with the specificity ofdiv
, not the specificty of:is(div, #unrelated)
:The implicit rule inside
@media
can now match pseudo-elements:The text was updated successfully, but these errors were encountered: