Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-nesting] Include CSSNestedDeclarations? #697

Closed
andruud opened this issue Sep 16, 2024 · 5 comments · Fixed by web-platform-tests/wpt-metadata#6743
Closed

[css-nesting] Include CSSNestedDeclarations? #697

andruud opened this issue Sep 16, 2024 · 5 comments · Fixed by web-platform-tests/wpt-metadata#6743
Labels
test-change-proposal Proposal to add or remove tests for an interop area

Comments

@andruud
Copy link

andruud commented Sep 16, 2024

Test List

(Add) css/css-nesting/nested-declarations-cssom.html
(Add) css/css-nesting/nested-declarations-matching.html

Rationale

Possibly a bit late to include in 2024, but checking to see if there's interest anyway. cc @emilio @mdubet

CC'd people already know, but I'll include some examples of potential interop pain anyway:


The implicit rule inside @media (color:green) now matches <div> with the specificity of div, not the specificty of :is(div, #unrelated):

div, #unrelated {
  color: red;
  @media (width > 400px) {
     color: green;
  }
}

The implicit rule inside @media can now match pseudo-elements:

div::before {
  content: "narrow";
  @media (width > 400px) {
     content: "wide"; /* Works now, didn't before */
  }
}
@andruud andruud added the test-change-proposal Proposal to add or remove tests for an interop area label Sep 16, 2024
@emilio
Copy link

emilio commented Sep 16, 2024

Fwiw it's already kind of included since you fixed the parsing tests, so WebKit and gecko are at ninety something percent now.

I think it's fine on our end, I plan to implement this change sooner rather than later anyways

@andruud
Copy link
Author

andruud commented Sep 16, 2024

Fwiw it's already kind of included since you fixed the parsing tests, so WebKit and gecko are at ninety something percent now.

Indeed. But if we don't agree to include CSSNestedDeclarations here, I can remove those tests (from interop, not from WPT), per #604.

@mdubet
Copy link

mdubet commented Sep 16, 2024

Fine on our side also 👍

@emilio
Copy link

emilio commented Sep 19, 2024

@andruud I just noticed that some of these tests have a dependency on @scope (which is not on by default in Firefox and not part of interop). Would you be fine if I made the test not depend on it (by either moving the test, or checking for window.CSSScopeRule or so)?

@andruud
Copy link
Author

andruud commented Sep 19, 2024

@emilio Oh, my bad. Yes, please move it.

i3roly pushed a commit to i3roly/firefox-dynasty that referenced this issue Sep 20, 2024
…smaug

I didn't put this behind a pref because it was a bit annoying to do with
the parser changes while keeping it fast, and because, at least nesting
wise, this is unlikely to cause compat issues.

There are some complexities for @scope, which I think I got right.

Fixed the tests not to depend on @scope necessarily per the discussion
in web-platform-tests/interop#697.

Differential Revision: https://phabricator.services.mozilla.com/D222817
moz-wptsync-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 20, 2024
I didn't put this behind a pref because it was a bit annoying to do with
the parser changes while keeping it fast, and because, at least nesting
wise, this is unlikely to cause compat issues.

There are some complexities for @scope, which I think I got right.

Fixed the tests not to depend on @scope necessarily per the discussion
in web-platform-tests/interop#697.

Differential Revision: https://phabricator.services.mozilla.com/D222817

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1918408
gecko-commit: 0aa1570bfecae9690855f6d6594e79f59593e36c
gecko-reviewers: dshin, webidl, smaug
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Sep 20, 2024
…smaug

I didn't put this behind a pref because it was a bit annoying to do with
the parser changes while keeping it fast, and because, at least nesting
wise, this is unlikely to cause compat issues.

There are some complexities for @scope, which I think I got right.

Fixed the tests not to depend on @scope necessarily per the discussion
in web-platform-tests/interop#697.

Differential Revision: https://phabricator.services.mozilla.com/D222817
github-actions bot pushed a commit to DioxusLabs/stylo that referenced this issue Sep 20, 2024
…smaug

I didn't put this behind a pref because it was a bit annoying to do with
the parser changes while keeping it fast, and because, at least nesting
wise, this is unlikely to cause compat issues.

There are some complexities for @scope, which I think I got right.

Fixed the tests not to depend on @scope necessarily per the discussion
in web-platform-tests/interop#697.

Differential Revision: https://phabricator.services.mozilla.com/D222817
moz-wptsync-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 20, 2024
I didn't put this behind a pref because it was a bit annoying to do with
the parser changes while keeping it fast, and because, at least nesting
wise, this is unlikely to cause compat issues.

There are some complexities for @scope, which I think I got right.

Fixed the tests not to depend on @scope necessarily per the discussion
in web-platform-tests/interop#697.

Differential Revision: https://phabricator.services.mozilla.com/D222817

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1918408
gecko-commit: 0aa1570bfecae9690855f6d6594e79f59593e36c
gecko-reviewers: dshin, webidl, smaug
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Sep 20, 2024
…smaug

I didn't put this behind a pref because it was a bit annoying to do with
the parser changes while keeping it fast, and because, at least nesting
wise, this is unlikely to cause compat issues.

There are some complexities for scope, which I think I got right.

Fixed the tests not to depend on scope necessarily per the discussion
in web-platform-tests/interop#697.

Differential Revision: https://phabricator.services.mozilla.com/D222817

UltraBlame original commit: 0aa1570bfecae9690855f6d6594e79f59593e36c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Sep 20, 2024
…smaug

I didn't put this behind a pref because it was a bit annoying to do with
the parser changes while keeping it fast, and because, at least nesting
wise, this is unlikely to cause compat issues.

There are some complexities for scope, which I think I got right.

Fixed the tests not to depend on scope necessarily per the discussion
in web-platform-tests/interop#697.

Differential Revision: https://phabricator.services.mozilla.com/D222817

UltraBlame original commit: 0aa1570bfecae9690855f6d6594e79f59593e36c
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this issue Sep 21, 2024
…smaug

I didn't put this behind a pref because it was a bit annoying to do with
the parser changes while keeping it fast, and because, at least nesting
wise, this is unlikely to cause compat issues.

There are some complexities for @scope, which I think I got right.

Fixed the tests not to depend on @scope necessarily per the discussion
in web-platform-tests/interop#697.

Differential Revision: https://phabricator.services.mozilla.com/D222817
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Sep 26, 2024
…smaug

I didn't put this behind a pref because it was a bit annoying to do with
the parser changes while keeping it fast, and because, at least nesting
wise, this is unlikely to cause compat issues.

There are some complexities for scope, which I think I got right.

Fixed the tests not to depend on scope necessarily per the discussion
in web-platform-tests/interop#697.

Differential Revision: https://phabricator.services.mozilla.com/D222817

UltraBlame original commit: 0aa1570bfecae9690855f6d6594e79f59593e36c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-change-proposal Proposal to add or remove tests for an interop area
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants