New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Total size hard coded to 48px #10

Open

helhum opened this issue Jun 18, 2021 · 1 comment

helhum commented Jun 18, 2021

May be I'm missing something, but could it be the that the total size of the icon is hard coded to 48px?

It is possible to set the icons size, but this will "only" reduce the size of the icon and at the same time increase the surrounding margin.

Is there a reason for that? If not, would you accept a pull request to change that?

Owner

web-padawan commented Jun 19, 2021

Hello, this is actually by design: using 48px helps to reserve enough space to make it easy to tap on mobile.

Please check the original project README: https://github.com/luukdv/hamburger-react#accessibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment