-
-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Some tests are not executed because the findBundle
option is not overriden
#9056
Comments
@GiveMe-A-Name I believe this issue may need to be reopened, as #9057 only partially addresses the problem. I've included some examples in the original issue for your reference. |
in your reproduce steps, eg and the failed case is failed due to |
@stormslowly Thank you for checking. The test case in
Here are the steps to reproduce the issue for the first example (
/** @type {import("../../../..").TConfigCaseConfig} */
module.exports = {
findBundle: (i, options) => {
return ["main.js"];
}
};
|
System Info
Details
It seems that some test cases in
packages/rspack-test-tools/tests/configCases/**/index.js
are not executed because thefindBundle
option is not overriden in thetest.config.js
file.A few of them can be easily fixed (#9057). Some may need further investigation because they will fail if the
findBundle
option is added.Examples of tests that are not executed and cannot be trivially fixed by simply adding a
test.config.js
file:Reproduce link
No response
Reproduce Steps
expect(1).toBe(2);
to the test case inpackages/rspack-test-tools/tests/configCases/plugins/source-map-dev-tool-plugin-file-context/index.js
.cd packages/rspack-test-tools/
pnpm run test:base -t config/plugins/source-map-dev-tool-plugin-file-context -u
and notice that two tests pass.packages/rspack-test-tools/tests/configCases/plugins/source-map-dev-tool-plugin-file-context/test.config.js
with the following content:pnpm run test:base -t config/plugins/source-map-dev-tool-plugin-file-context -u
again and notice that this time two tests pass but one fails due to the added lineexpect(1).toBe(2);
.The text was updated successfully, but these errors were encountered: