Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: register cleanup hook on global #8564

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf: register cleanup hook on global #8564

wants to merge 1 commit into from
+14 −18

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Nov 28, 2024 •
edited
Loading

Summary

Only call add_env_cleanup_hook in Rspack constructor to reduce memory usage.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Nov 28, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 111e3b3
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67484cb996510000088cc4de

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #8564 will not alter performance

Comparing perf-one-shot-value-ref (111e3b3) with main (21edaba)

Summary

✅ 1 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SyMind