Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement output.clean.keep: Option<string> #8479

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: implement output.clean.keep: Option<string> #8479

wants to merge 11 commits into from
+376 −53

Conversation

ClSlaid
Copy link

@ClSlaid ClSlaid commented Nov 19, 2024 •
edited
Loading

Summary

Part of #7822

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Nov 19, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 19, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit b16e52c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/674432766706170008980115

@ClSlaid
Copy link
Author

ClSlaid commented Nov 20, 2024

/cc @h-a-n-a I wonder where I can add tests?

@inottn
Copy link
Collaborator

inottn commented Nov 20, 2024

You can write test cases under packages/rspack-test-tools/tests/configCases/clean/ignore-string.

@ClSlaid ClSlaid marked this pull request as draft November 23, 2024 19:57
@ClSlaid ClSlaid force-pushed the feat/webpack/output-clean branch 2 times, most recently from d699d3d to f123bd8 Compare November 23, 2024 20:11
ClSlaid
ClSlaid commented Nov 23, 2024
View reviewed changes
Copy link
Author

@ClSlaid ClSlaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @inottn help needed here.

crates/node_binding/binding.d.ts Show resolved Hide resolved
@ClSlaid ClSlaid marked this pull request as ready for review November 24, 2024 19:09
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 25, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #8479 will not alter performance

Comparing ClSlaid:feat/webpack/output-clean (b16e52c) with main (eb12150)

Summary

✅ 1 untouched benchmarks

@ClSlaid ClSlaid requested a review from inottn November 25, 2024 05:31
@inottn
Copy link
Collaborator

inottn commented Nov 25, 2024

Let's first ensure that the CI passes successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inottn inottn Awaiting requested review from inottn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ClSlaid @CLAassistant @inottn